3fdbd994e0
Privatize low-level adb functions
...
Only expose the interruptible user-friendly API.
4 years ago
ce225f019a
Use new user-friendly adb API
...
Replace the adb_exec_*() calls by the new adb functions to simplify.
4 years ago
b7559744a7
Expose new user-friendly adb functions
...
Expose interruptible adb functions which return the expected result
directly, without exposing the process (sc_pid) to the caller.
4 years ago
afb5a5e80f
Rename adb functions to adb_exec_*
...
This paves the way to replace them by more user-friendly functions that
will call them internally.
4 years ago
84334cf7db
Use sc_intr in file_handler
...
Replace manual interruption handling by the recent sc_intr mechanism.
4 years ago
0ba2686e1d
Simplify file_handler
...
Call the target functions directly.
4 years ago
55648d4d64
Improve file_handler readability
...
Use local variables as short name aliases.
4 years ago
13fd693b50
Simplify adb_execute_p()
...
Only pass the stdout pipe as parameter, scrcpy never writes to stdin or
reads from stderr of an adb process.
4 years ago
0426ae885c
Make "adb get-serialno" interruptible
...
All process executions must be interruptible, so that Ctrl+c reacts
immediately.
4 years ago
ea454e9cee
Add interruptible function to read from pipe
...
This will avoid to block Ctrl+c if the process the pipe is read from
takes too much time.
4 years ago
cb65531533
Simplify sc_str_truncate()
...
Use strcspn() to get the prefix length directly.
4 years ago
9619ade706
Generalize string trunctation util function
...
Add an additional argument to let the client pass the possible end
chars.
4 years ago
f2781a8b6d
Expose util function to truncate first line
...
Move the local implementation from adb functions to the string util
functions.
4 years ago
443cb14d6e
Assume non-NULL serial in file_handler
...
The previous commit guarantees to always initialize the serial, so the
file_handle may assume it is never NULL.
4 years ago
b30c3a429f
Always retrieve device serial
...
This allows to execute all adb commands with the specific -s parameter,
even if it is not provided by the user.
In practice, calling adb without -s works if there is exactly one device
connected. But some adb commands (for example "adb push" on drag & drop)
could be executed after another device is connected, so the actual
device serial must be known.
4 years ago
632bd5697b
Add missing error handling
...
If "adb get-serialno" fails, attempting to read from the uninitialized
pipe is incorrect.
4 years ago
de50846905
Close process on check success
...
The interruptible version of the function to check process success
(sc_process_check_success_intr()) did not accept a close parameter to
avoid a race condition. But as the result, the processes were not closed
at all.
Add a close parameter, and close the process separately to avoid the
race condition.
4 years ago
ee93d2aac1
Configure init and cleanup asynchronously
...
Accessing the settings (like --show-touches) on start should not delay
screen mirroring.
PR #2802 <https://github.com/Genymobile/scrcpy/pull/2802 >
4 years ago
c29a0bf675
Do not quit on cleanup configuration failure
...
Cleanup is used for some options like --show-touches to restore the
state on exit.
If the configuration fails, do not crash the whole process. Just log an
error.
PR #2802 <https://github.com/Genymobile/scrcpy/pull/2802 >
4 years ago
411bb0d18e
Move init and cleanup to a separate method
...
PR #2802 <https://github.com/Genymobile/scrcpy/pull/2802 >
4 years ago
cc0902b13c
Read/write settings via command on Android >= 12
...
Before Android 8, executing the "settings" command from a shell was
very slow (~1 second), because it spawned a new app_process to execute
Java code. Therefore, to access settings without performance issues,
scrcpy used private APIs to read from and write to settings.
However, since Android 12, this is not possible anymore, due to
permissions changes.
To make it work again, execute the "settings" command on Android 12 (or
on previous version if the other method failed). This method is faster
than before Android 8 (~100ms).
Fixes #2671 <https://github.com/Genymobile/scrcpy/issues/2671 >
Fixes #2788 <https://github.com/Genymobile/scrcpy/issues/2788 >
PR #2802 <https://github.com/Genymobile/scrcpy/pull/2802 >
4 years ago
48b572c272
Add throwable parameter to Log.w()
...
When an exception occurs, we might want to log a warning instead of an
error.
PR #2802 <https://github.com/Genymobile/scrcpy/pull/2802 >
4 years ago
94feae71f2
Report settings errors via Exceptions
...
Settings read/write errors were silently ignored. Report them via a
SettingsException so that the caller can handle them.
This allows to log a proper error message, and will also allow to
fallback to a different settings method in case of failure.
PR #2802 <https://github.com/Genymobile/scrcpy/pull/2802 >
4 years ago
67170437f1
Wrap settings management into a Settings class
...
Until now, the code that needed to read/write the Android settings had
to explicitly open and close a ContentProvider.
Wrap these details into a Settings class.
This paves the way to provide an alternative implementation of settings
read/write for Android >= 12.
PR #2802 <https://github.com/Genymobile/scrcpy/pull/2802 >
4 years ago
57fb08e443
Update Simplified Chinese README to 1.20
...
PR #2786 <https://github.com/Genymobile/scrcpy/pull/2786 >
Signed-off-by: Romain Vimont <rom@rom1v.com>
4 years ago
02ae0db6cd
Fix wrong package to install for Ubuntu/Debian
...
Without this package, meson fails:
Run-time dependency libusb-1.0 found: NO (tried pkgconfig and cmake)
app/meson.build:88:8: ERROR: Dependency "libusb-1.0" not found, tried pkgconfig and cmake
PR #2790 <https://github.com/Genymobile/scrcpy/pull/2790 >
Signed-off-by: Romain Vimont <rom@rom1v.com>
4 years ago
9cb14b5166
Inherit only specific handles on Windows
...
To be able to communicate with a child process via stdin, stdout and
stderr, the CreateProcess() parameter bInheritHandles must be set to
TRUE. But this causes *all* handles to be inherited, including sockets.
As a result, the server socket was inherited by the process running adb
to execute the server on the device, so it could not be closed properly,
causing other scrcpy instances to fail.
To fix the issue, use an extended API to explicitly set the HANDLEs to
inherit:
- <https://stackoverflow.com/a/28185363/1987178 >
- <https://devblogs.microsoft.com/oldnewthing/20111216-00/?p=8873 >
Fixes #2779 <https://github.com/Genymobile/scrcpy/issues/2779 >
PR #2783 <https://github.com/Genymobile/scrcpy/pull/2783 >
4 years ago
9cb8766220
Factorize resource release after CreateProcess()
...
Free the wide characters string in all cases before checking for errors.
4 years ago
fd4ec784e0
Remove useless assignments on error
...
Leave the output parameter untouched on error.
4 years ago
52cebe1597
Fix Windows sc_pipe function names
...
The implementation name was incorrect (it was harmless, because they are
not used on Windows).
4 years ago
6a27062f48
Stop connection attempts if interrupted
...
If the interruptor is interrupted, every network call will fail, but the
retry-on-error mechanism must also be stopped.
4 years ago
739ff9dce0
Fix compilation errors with old SDL versions
...
SDL_PixelFormatEnum has been introduced in SDL 2.0.10:
<cc6a8ac87ea1c11854f2Fixes #2777 <https://github.com/Genymobile/scrcpy/issues/2777 >
PR #2781 <https://github.com/Genymobile/scrcpy/pull/2781 >
Reviewed-by: Yu-Chen Lin <npes87184@gmail.com>
4 years ago
65b023ac6d
Update links to v1.20
4 years ago
a045e28df8
Bump version to 1.20
4 years ago
52138fd921
Update script to build without gradle to SDK 31
...
Build tools 31.x.x do not ship dx anymore. Use d8 instead.
Refs 8bf28e9f53
4 years ago
1bb0df5da1
Extract ANDROID_JAR path in build script
...
This will allow to reuse it.
4 years ago
562ec6e9b3
Merge branch 'master' into dev
4 years ago
1be5daf999
Fix word order in README
4 years ago
57387fa707
Mention crash on Android 12 on old scrcpy in FAQ
4 years ago
4e811a4a68
Adapt icon in README
...
Use SVG format, align to the right, and reduce its size.
4 years ago
99a4a48477
Replace "connected on" to "connected via"
...
I'm not sure "connected on USB" is correct.
4 years ago
1d97d77032
Improve scrcpy presentation in README
4 years ago
45b0f8123a
Increase delay to inject HID on Ctrl+v
...
2 milliseconds turn out to be insufficient sometimes. It seems that 5
milliseconds is enough (and still not noticeable).
4 years ago
c1a34881d7
Use sc_ prefix for server
4 years ago
057c7a4df4
Move str_util to str
...
Simplify naming.
4 years ago
979ce64dc0
Improve string util API
...
Use prefixed names and improve documentation.
4 years ago
9a0bd545d5
Rename SC_INVALID_SOCKET to SC_SOCKET_NONE
...
For consistency with SC_PROCESS_NONE.
4 years ago
c4d008b96a
Extract adb tunnel to a separate component
...
This simplifies the server code.
4 years ago
0d45c29d13
Move IPV4_LOCALHOST to net.h
...
This constant will be used from several files.
4 years ago
37c840a4c8
Interrupt on process terminated
...
Interrupt any blocking call on process terminated, like on
server_stop().
This allows to interrupt any blocking accept() with correct
synchronization without additional complexity.
4 years ago
Romain Vimont
LuXu
Alex Burdusel